Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove dependencies] Convert some default format to external package #321

Closed
A-312 opened this issue Sep 9, 2019 · 0 comments
Closed

Comments

@A-312
Copy link
Contributor

A-312 commented Sep 9, 2019

With lerna a github repo could have several npm package see this repo. And we can get this folder structure :

packages/
# validator
packages/ipaddress/
packages/email/
packages/url/
# moment.js
packages/duration/
packages/timestamp/
test/
lib/
...
package.json

I propose to outsource format using validator and moment.js (#317) according to #303 (comment).

We have to replace this line : https://github.com/mozilla/node-convict/blob/master/lib/convict.js#L213 I think we can use directly indexOf because 'x' must be a string and this is enough for string value !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant