-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a full path to download the file to #92
Comments
On first use of mozdownload I was curious about this functionality also. My first thought was -d and --dest. Which would be as you've described; a destination path/file, or path/ only, which preserves the original file. ie. deprecating --directory. My first interpretation of --target was of a thing that already exists, but that could just be me. |
Using -d and --dest works for me. It would also mean no obvious changes to anyone already using -d and specifying a directory. |
Are you interested in working on this @tojonmz? |
I have a backlog of other Issues/bugs on the go right now so it's probably best to open this up to anyone. |
Hm, issue #12 might actually cover part of that, maybe all. |
I would like to work on this |
Ujjwal, you are welcome! Let me know if you need help. Also in regards of the patch, we will need an automated test which verifies the functionality of the new feature. Thanks! |
PR #234 has been merged. Thanks a lot! |
With bug 857037 we will be removing support for running automation against binaries in a directory. Instead, automation will target a specific binary, but mozdownload does not currently support specifying the filename of the downloaded content.
We should add an
--target
option (and potentially remove the--directory
option). If not specified we should download to the current directory. If a directory is specified we should retain the remote filename and download it to the specified local directory. If a full path and filename is specified then we should download to the specified local file.The text was updated successfully, but these errors were encountered: