Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a full path to download the file to #92

Closed
davehunt opened this issue Jun 4, 2013 · 8 comments
Closed

Allow specifying a full path to download the file to #92

davehunt opened this issue Jun 4, 2013 · 8 comments
Assignees
Milestone

Comments

@davehunt
Copy link
Member

davehunt commented Jun 4, 2013

With bug 857037 we will be removing support for running automation against binaries in a directory. Instead, automation will target a specific binary, but mozdownload does not currently support specifying the filename of the downloaded content.

We should add an --target option (and potentially remove the --directory option). If not specified we should download to the current directory. If a directory is specified we should retain the remote filename and download it to the specified local directory. If a full path and filename is specified then we should download to the specified local file.

@tojon
Copy link

tojon commented Jun 7, 2013

On first use of mozdownload I was curious about this functionality also. My first thought was -d and --dest. Which would be as you've described; a destination path/file, or path/ only, which preserves the original file. ie. deprecating --directory. My first interpretation of --target was of a thing that already exists, but that could just be me.

@davehunt
Copy link
Member Author

davehunt commented Jun 7, 2013

Using -d and --dest works for me. It would also mean no obvious changes to anyone already using -d and specifying a directory.

@davehunt
Copy link
Member Author

Are you interested in working on this @tojonmz?

@tojon
Copy link

tojon commented Jul 16, 2013

I have a backlog of other Issues/bugs on the go right now so it's probably best to open this up to anyone.

@whimboo
Copy link
Contributor

whimboo commented May 15, 2014

Hm, issue #12 might actually cover part of that, maybe all.

@ujjwalwahi
Copy link
Contributor

I would like to work on this

@whimboo
Copy link
Contributor

whimboo commented Jan 14, 2015

Ujjwal, you are welcome! Let me know if you need help. Also in regards of the patch, we will need an automated test which verifies the functionality of the new feature. Thanks!

@whimboo
Copy link
Contributor

whimboo commented Mar 3, 2015

PR #234 has been merged. Thanks a lot!

@whimboo whimboo closed this as completed Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants