Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style blockquotes for readabiltity #1924

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Style blockquotes for readabiltity #1924

merged 1 commit into from
Sep 3, 2024

Conversation

dotproto
Copy link
Collaborator

@dotproto dotproto commented Aug 2, 2024

Currently, blockquote styling is not well suited for multi-line text. We currently only have one blockquote in our documentation. This PR migrates the styling of that blockquote into the site-wide rules and removes the existing inline styling.

This PR was originally part of PR #1918.

@rebloor
Copy link
Collaborator

rebloor commented Aug 5, 2024

@dotproto got a screenshot of what the new style looks like?

@rebloor rebloor added the content label Aug 5, 2024
@willdurand willdurand self-requested a review August 5, 2024 15:47
@dotproto
Copy link
Collaborator Author

Before
Screenshot 2024-08-26 at 10 12 30 AM

After

Screenshot 2024-08-26 at 10 14 12 AM

@dotproto dotproto requested a review from rebloor August 28, 2024 05:21
Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result looks fine to me.

@dotproto dotproto merged commit 7b66572 into master Sep 3, 2024
1 check passed
@dotproto dotproto deleted the blockquote branch September 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants