Add support for transparent enums #992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
force-pushed
the
transparent-enums
branch
from
8c76d22
to
afa9286
Compare
youknowone
reviewed
Nov 6, 2024
| #[repr(transparent)] | ||
| struct TransparentComplexWrappingStructure { only_field: DummyStruct } | ||
| struct TransparentComplexWrappingStruct { only_field: DummyStruct } |
There was a problem hiding this comment.
I like this patch in general, but these changes which are not related to the changed behavior makes a bit harder to read the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code restructuring work that allows transparent typedefs (see #966) makes it straightforward to also support rust's transparent enums if we want to do so. Add the support, including accompanying tests and documentation.
NOTE: This PR is currently stacked on top of #966, so the first two commits should be ignored while reviewing.