Fallback to empty list when block type is not present #22846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on cache.json"" This reverts commit 2bd0783.
KevinMind
force-pushed
the
fix-missing-cache
branch
from
72a897f
to
51eb173
Compare
KevinMind
changed the title
willdurand
requested changes
Nov 13, 2024
KevinMind
force-pushed
the
fix-missing-cache
branch
from
caf40e8
to
e44f811
Compare
KevinMind
force-pushed
the
fix-missing-cache
branch
from
e44f811
to
633fbd5
Compare
KevinMind
added a commit
that referenced
this pull request
Nov 13, 2024
* Revert "Revert "Fallback to empty list when block type is not present on cache.json"" This reverts commit 2bd0783. * Add regression test + comment * Format * Validate diff adds and omits from corupted cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2bd0783.
Fixes: mozilla/addons#15163
Context
After #22715 we introduced
soft_blockedkey to the cache.json, however the first time we ran the filter it compared to a cache.json that did not have soft_blocked and this led to failures when generating diffs.This should really never happen after the first iteration but it's good to have this fallback in place if for any reason we have a broken cache.json
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.