Split diff by block type #22830
Merged
Split diff by block type #22830
+312
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
mlbf-split-diff
branch
from
9321d21
to
4fea195
Compare
KevinMind
force-pushed
the
mlbf-split-diff
branch
from
4fea195
to
d8f9fce
Compare
5 tasks
eviljeff
reviewed
Nov 7, 2024
willdurand
requested changes
Nov 8, 2024
Co-authored-by: William Durand <[email protected]>
KevinMind
force-pushed
the
mlbf-split-diff
branch
from
0e8d92e
to
790773b
Compare
Co-authored-by: William Durand <[email protected]>
KevinMind
force-pushed
the
mlbf-split-diff
branch
from
790773b
to
1459119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #22826
Relates to: #22828
Fixes: mozilla/addons#15147
Description
Split
generate_diffsto include diffs for both hard and soft blocks. This is required for both stashing and filter updates.Context
This patch is required by both of the linked PRs and to keep them independent we should land this (trivial) change first and rebase the other two.
Testing
This is a backaward compatible patch so automated testing is fine.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.