Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint does not pick up unsupported tabs.update options for Firefox for Android #5429

Open
willlma opened this issue Aug 20, 2024 · 0 comments

Comments

@willlma
Copy link

willlma commented Aug 20, 2024

Is this a feature request or a bug?

A bug

What is the current behavior?

When I use Tabs.update with the loadReplace option, like so:

tabs.update(permittedTabId, { url, loadReplace: true });

It works well on Firefox for desktop, but in Firefox for Android I get this error when running the extension:

Error: Type error for parameter updateProperties (Unexpected property "loadReplace") for tabs.update.

This is well documented in the browser compatibility docs, but when I use the linter to detect these types of issues as described in Developing extensions for Firefox for Android,

web-ext lint

The output does not include any mention of ANDROID_INCOMPATIBLE_API

What is the expected or desired behavior?

The output should contain ANDROID_INCOMPATIBLE_API stating that the usage of Tabs.update with the loadReplace option is not supported by Firefox for Android.

Version information (for bug reports)

  • Firefox version: 130 on both Desktop and Android
  • Your OS and version: MacOS Sonoma 14.5
  • Paste the output of these commands:
node --version && npm --version && npx web-ext --version
v19.8.1
9.5.1
7.12.0
@rpl rpl transferred this issue from mozilla/web-ext Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant