Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1476107 - Implement new Markdown editor widget with text formatting toolbar and keyboard shortcuts #2307

Merged

Conversation

kyoshino
Copy link
Collaborator

@kyoshino kyoshino commented Sep 1, 2024

Bug 1476107 - Implement new Markdown editor widget with text formatting toolbar and keyboard shortcuts

This is a revised version of my previous PR #1361. Improvements include mobile optimization, new attachment overlay support, cleaner UI, and keyboard handling.

  • Implement a text formatting toolbar for bold, italic, code, link, heading, quote, numbered list, bulleted list
  • Add keyboard shortcuts for bold, italic, code, link
  • Add Enter key handling for list items
  • Consolidate all the editor and preview code, including the inline comment editor
  • Replace deprecated Material Icons with Material Symbols to use the heading icon
  • Avoid using web components due to a11y concerns

@dklawren dklawren self-requested a review September 3, 2024 18:13
@kyoshino kyoshino force-pushed the bug-1476107-markdown-editor-rev branch from ab05973 to 3f06ca9 Compare September 3, 2024 21:15
Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just some minor changes/bugs.

@dklawren
Copy link
Collaborator

dklawren commented Sep 16, 2024

I found another display glitch that will need to be fixed.

If you have your user preferences to show the comment field before older comments, then initially things look OK

image

But if you click 'Edit Bug' at the top, then things look wrong:

image

When clicking 'Edit Bug', an extra 'Save Changes' button appears and throws off the layout.

Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! r=dkl

@dklawren dklawren merged commit 3c1d1d6 into mozilla-bteam:master Sep 17, 2024
17 checks passed
@kyoshino kyoshino deleted the bug-1476107-markdown-editor-rev branch September 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants