Bug 1909798 - Large dependency graphs do not work #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsheeh
requested changes
Jul 26, 2024
showdependencygraph.cgi
Outdated
| @@ -76,16 +76,16 @@ my $add_link = sub { | |||
|
|
|||
| $link_text .= $dependson; | |||
| $link_text .= ($dependson_status eq 'RESOLVED') ? '[' : '(['; | |||
| $link_text .= "$dependson"; | |||
| $link_text .= '"' . $dependson; | |||
There was a problem hiding this comment.
This seems like it's likely to break in the future... could you build up the variable to be quoted in a separate variable and then just $link_text .= '"$dependson_text"'; instead?
|
Admittedly the add_link function is getting very complex and in the future I would like to break it apart into smaller manageable chunks. I have pushed the latest fixes in this PR to bugzilla-dev for you to try out. Here is the original bug causing the breakage in its full, practically unreadable glory. Hopefully most dependency trees will not be this large. |
cgsheeh
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added quotes around the bug id and summaries which should with future special characters that Mermaid treats as special.