Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notary from URL doesn't work #171

Open
r-st opened this issue Apr 5, 2013 · 4 comments
Open

Adding notary from URL doesn't work #171

r-st opened this issue Apr 5, 2013 · 4 comments

Comments

@r-st
Copy link

r-st commented Apr 5, 2013

Steps to reproduce:

  1. In Convergence preferences click to Add Notary.
  2. Fill the remote .notary URL.
  3. Click OK.

Expected result:
New notary is added.

Actual result:
Nothing happens.

Versions:
Firefox 19.0.2 and 20.0
Convergence 0.09 vanilla and patched with patch from #170.

@mk-fg
Copy link

mk-fg commented Apr 28, 2013

For me the problem was in invalid number of arguments passed to nsIWebBrowserPersist.saveURI in client/chrome/content/util/ConvergenceUtil.js.
Can be fixed by simply passing null as the last argument (since we only care about the contents there).

I've pushed this one fix to fix_adding_notaries_from_url branch - you might want to try running that, but not sure if it's an upstreamable solution as it'll probably break older FF versions (which worked with originial call).

@r-st
Copy link
Author

r-st commented May 1, 2013

Now it works, thanks.

@r-st r-st closed this as completed May 1, 2013
@mk-fg
Copy link

mk-fg commented May 1, 2013

Was probably a bit unclear (sorry) in "pushed this one fix to ... branch" - that branch is in my fork, so I think it's still a valid issue in this repo, thus might be worth keeping it open (i.e. reopening) in case someone else stumbles upon it and/or @moxie0 (or whatever valid comitters) find time to look at it here.

@r-st
Copy link
Author

r-st commented May 1, 2013

OK, reopening :-)

@r-st r-st reopened this May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants