Replies: 1 comment 1 reply
-
So, I think we can start identifying tasks here. Can you list areas you would want to prioritize? Wd can then use learnings from improving tests there to improve elsewhere. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We need to improve protocol unit tests and get them run in CI.
Carrying over notes from #393:
Unit tests are written to support development and check for regressions, mainly in protocol units and utility crates.
No external infrastructure
Currently, our tests include infrastructure-dependent integration style tests, requiring local or remote service setup to run and feature-gated out of the default
cargo test
run. This should be avoided and mocking should be implemented instead.One exception is boostrapping of file storage, configuration files, and similar as needed for test execution. This should be performed in temporary directories that are cleaned up at the end of a test.
More heavyweight local setup (e.g. bringing up Anvil and deploying the MCR contract) is possible, but it's impractical to do for every test. Reusing the infra between test cases is possible as a once-init, but this creates test dependency issues.
Short-term priorities
Beta Was this translation helpful? Give feedback.
All reactions