You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The established pattern in warehouse_ros is to pass const std::string& to prevent a copy.
However this prevents use of the more modern std::string_view in code building on top of warehouse_ros, forcing them to copy into an std::string just to call into methods of warehouse_ros (when a copy would've been prevented in the first place!).
Since we moved to C++17 in Galactic, which supports std::string_view, we probably should move to using std::string_view instead.
I'm not sure if there are any issues with just doing a sweeping find and replace though, for anyone depending on warehouse_ros?
The text was updated successfully, but these errors were encountered:
The established pattern in
warehouse_ros
is to passconst std::string&
to prevent a copy.However this prevents use of the more modern
std::string_view
in code building on top ofwarehouse_ros
, forcing them to copy into anstd::string
just to call into methods of warehouse_ros (when a copy would've been prevented in the first place!).Since we moved to C++17 in Galactic, which supports
std::string_view
, we probably should move to usingstd::string_view
instead.I'm not sure if there are any issues with just doing a sweeping find and replace though, for anyone depending on
warehouse_ros
?The text was updated successfully, but these errors were encountered: