disable hooks for unused rviz-based task construction #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 90 90
Lines 8484 8484
=======================================
Hits 5006 5006
Misses 3478 3478
☔ View full report in Codecov by Sentry. |
this implementation is far from functional right now and the button confuses users.
v4hn
force-pushed
the
pr-disable-unused-panel
branch
from
d78e1be
to
fb3e974
Compare
v4hn
commented
Oct 11, 2023
|
The tooltip was defined in the .ui file as well. |
|
To answer your remaining questions: I didn't yet give up on building the construction interface, but I didn't find time... |
LeroyR
pushed a commit
to CentralLabFacilities/moveit_task_constructor
that referenced
this pull request
Oct 26, 2023
v4hn
added a commit
to v4hn/moveit_task_constructor
that referenced
this pull request
Nov 28, 2023
captain-yoshi
pushed a commit
to captain-yoshi/moveit_task_constructor
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is far from functional right now and the button confuses users.
@rhaschke I don't know whether you want to keep the whole underlying framework (which is quite sophisticated) around, so I just disabled the UI hook.
I believe you also moved on to specifying tasks in python instead of trying to set them up visually.