Fix docs build #933
Merged
Fix docs build #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
commented
Jul 31, 2024
| @@ -7,5 +7,6 @@ build | |||
| Gemfile | |||
| native_build | |||
| *.gdb | |||
| .venv | |||
There was a problem hiding this comment.
@stephanie-eng adding to gitignore since following the new instructions will create this folder locally
There was a problem hiding this comment.
Good point, thanks for the fix
sea-bass
commented
Jul 31, 2024
| @@ -36,7 +36,7 @@ To start the hybrid planning demo simply run: :: | |||
|
|
|||
| You should see a similar behavior as in the example GIF above without the replanning. | |||
|
|
|||
| To interact with the architecture you simply need to send a *Hybrid Planning Request* to an action server offered by the *Hybrid Planning Manager* as seen in the :moveit_codedir:`hybrid_planning_test_node <moveit_ros/hybrid_planning/test/hybrid_planning_demo_node.cpp#L245>`. | |||
| To interact with the architecture you simply need to send a *Hybrid Planning Request* to an action server offered by the *Hybrid Planning Manager*. | |||
There was a problem hiding this comment.
@sjahr This file was removed from the moveit2 repo last year with the promise that it would eventually be moved to this repo with a refresh of the Hybrid Planning tutorials. I assume this whole file would then get revisited.
stephanie-eng
approved these changes
Jul 31, 2024
henningkayser
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes an attempt at "fixing" the docs build.
I had to modify the
doxylinkrepo (see sphinx-contrib/doxylink#59) since there was an exception without this, and also removed/replaced some old links to make htmlproofer happy.While the exception was fixed with my PR above, there are still some more build warnings, so I had to remove the
-Wflag from thesphinx-buildcall inhtmlproofer.sh.I figured it would be better if the docs actually built and then someone else can try fix the warnings (or change the whole docs build system, which is probably due at this point)
Checklist