Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moveitpy ur #837

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Moveitpy ur #837

wants to merge 3 commits into from

Conversation

Mennosytsma
Copy link

@Mennosytsma Mennosytsma commented Dec 11, 2023

Description

Added a launch file and description on how run this with a simulated robot for the moveitpy tutorial combined with an UR robot as described in #810.

I don't have any experience with contributing code to an open source community like this and tried my best to follow the style guidelines and make as few changes as possible. If changes need to be made to this, please take some time to clearly explain to me what needs to be updated and I will review again what I did.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great tutorial -- thank you for working on this!

However, I think many users who are trying to run the default tutorials may run into trouble with all the installation steps to make sure the UR related dependencies are installed on their system.

As such, I would recommend maybe making this into a new repository, and maybe in this repo we can start a new doc page with external tutorials/examples for other common robots, and link to your work? I would be happy to support this, if you agree.

@apollo-elad
Copy link

apollo-elad commented Jan 23, 2024

any chance of adding a real-robot tutorial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants