Revert "Eliminate ability to keep multiple collision detectors updated" #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2021
|
I don't think we should merge this, even if it does fix the issues. It adds about 10% more code and a fair bit of complexity to the planning scene :( |
swilcock0
added a commit
to swilcock0/ros2_docker
that referenced
this pull request
May 7, 2021
This comment has been minimized.
This comment has been minimized.
|
I tested this in tutorials and this fix works for me. The robot now respects the attached collision object as intended. However as @AndyZe said we may need to a little deep and try to find which part of the original PR caused the issue. |
|
This does also fix #407 |
|
It can fixed #444 |
swilcock0
added a commit
to swilcock0/ros2_docker
that referenced
this pull request
May 21, 2021
Fix New fix]
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #407
Fix: #444
Fix: #429
Reverts #364
I wasn't able to trace where the bug is actually happening (it only happen when the planning scene have a parent scene), so just reverting it for now