-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add freebsd_init to extras please #2610
Comments
I suggest to merge BSDish setup into the existing |
A good suggestion. That would mean linux_init would need to be rewritten to NOT depend on bash and instead lean on normal sh semantics. |
Ah, no bash on BSD? However, shouldn't be a big deal and has other benefits to be bourne shell compatible. I wanted to add some info output to the script anyway, probably Btw, there is an old PR to add better FreeBSD support. Would be great if this was updated/recreated based on dev branch: #1616 |
The default and available shells on BSD are /bin/sh, /bin/csh and /bin/tcsh. bash can be installed, but then you're looking at additional and in my humble opinion uneeded requirements. It installs under /usr/local/bin so in that case you'd actually have to ensure all scripts' shebang line read '#!/usr/bin/env bash' so as to PATH gets used. To ensure it works everywhere, at least as many locations as humanly possible, a shebang line that reads '#!/bin/sh' and follows IEEE Std 1003.1 is a safe bet of working no matter where it runs. |
I'd actually use |
As for the other reference to #1616 I read through it and even though I understand it's trying to add support for FreeBSD I'm not actually effected by any of the problems it's trying to fix. For example, sha1sum exists on FreeBSD and the command works as described without needing a patch. The whole disk section of detecting disks, I have no idea why motioneye is doing disk detection at all. In the motioneye control panel, it's seeing the disk it's writing to and properly reporting on usage, but besides this I have no idea what its purpose is for. I'm using zfs instead of ufs and perhaps that's the reason why it's working for me? I'm not sure. |
Have these FreeBSD improvements made it into the dev branch? |
May need to move https://github.com/motioneye-project/motioneye/blob/dev/motioneye/extra/linux_init into here as they have freebsd rolled in with linux it seems per: motioneye-project/motioneye#2610
at least until freebsd.init is accepted motioneye-project/motioneye#2610
* First crack at Python3 MotionEye initial splatter * Can I Haz Python3 branch? trying to make version that pulls artefact for Python3 branch * case sense? maybe so get branch name exact * No Can Haz release doesn't work, lets see if branch is a option? * cloned my own artifact Trying to point at Python3 artifact branch is given up. Made a clone repo with new name for python3 artifact and will see if this works * trying python3.9 instead of 3.11 perhaps to cutting edge? * adding bash so linux.init can work at least until freebsd.init is accepted motioneye-project/motioneye#2610 * restoring artefact if the branch command works this should enable pushing this back to iX and have both old python 2 version work on artefact branch of master and when the python3 PR is accepted to this .json it should work with python3 branch of artefact. Once this manifest is live then can do PR to remove branch tag at same time as merging artefact branches. * forgot revision update revision to help with plug-in update * branch variable doesn't work iocage fetch supports branch variable to allow for artefact repo support of transitioning. However, the manifest doesn't seem to. Using temp artifact to enable transition without breaking anything if I miss the merg.
Attached you'll find a freebsd_init.txt file. (Should be renamed to freebsd_init but github wanted a file extension)
freebsd_init.txt
Please include this to your extras directory.
Appreciate it!
The text was updated successfully, but these errors were encountered: