Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name for requests in stats #272

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

daylikon
Copy link

Hi, @mostafa

Is it possible to add this to the plugin?
Or, for example, make a similar implementation for passing name to tags.

Ref: #271

Thank you

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mostafa
Copy link
Owner

mostafa commented Feb 5, 2024

Hey @daylikon,

I totally understand what you're trying to achieve with this, but this will generate too many metrics, that is, the cardinality of the metrics will increase under load, and it might cause a bunch of issues, and one being the increasing cost of storing and processing those metrics. Thus, I am not sure whether to merge this or not.

@mostafa
Copy link
Owner

mostafa commented Apr 3, 2024

Hey @daylikon,

Unless this tag is optional, I won't merge this PR. If you want this to be merged, please update the code to make it optional, otherwise we can close it.

@mostafa mostafa linked an issue Apr 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field with the name of the request in k6 stats
2 participants