Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing profile section to settings #607

Open
nayakrounak opened this issue Mar 2, 2023 · 13 comments
Open

Changing profile section to settings #607

nayakrounak opened this issue Mar 2, 2023 · 13 comments
Assignees
@Sujithbn
Labels
MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Milestone
10th MAR 23

Comments

@nayakrounak
Copy link

nayakrounak commented Mar 2, 2023 •
edited
Loading

Problem Statement

There is no profile concept in Inji. The options currently working here are actually settings. As part of this issue, we would be changing the profile to settings with some label changes and hiding some features.

Resolution

  • Change the profile icon to a cogwheel, so that, it looks like a settings option on the home screen.
  • Change the heading for the profile page from "PROFILE" to "SETTINGS".
  • Remove the option - "Credits and Legal Notice" and add a docs page in the source code for Credits.
  • Hide the option - "Revoke ID"
  • Hide the option - "Unlock Auth Factor"
  • Remove the option - VC Label and the default value for VC Lable should be "Card".
  • Change the label for "Biometric Unlock".

Screenshot

image
@nayakrounak nayakrounak added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels Mar 2, 2023
@nayakrounak
Copy link
Author

@SwatiPeriwal, Please provide the label for Biometric Unlock.

@Sujithbn Sujithbn added the MEC targeted for MEC label Mar 3, 2023
@Sujithbn Sujithbn modified the milestones: 6th MAR 23, 13th MAR 23 Mar 3, 2023
@Sujithbn Sujithbn added task Non functional tasks and removed enhancement New feature or request labels Mar 3, 2023
@SwatiPeriwal
Copy link

@nayakrounak Think we can use Unlock using Biometrics / Unlock Biometrics

@nayakrounak Display the QR Code to request/receive resident ID (please review and trim as required)

@krishnakumar4a4
Copy link
Contributor

@PuBHARGAVI is looking into this

@SwatiPeriwal
Copy link

SwatiPeriwal commented Mar 6, 2023 via email

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 6, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] change the labels in the app profile …
b799d64 
…screen
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 7, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] change the Id type to card type in th…
5d6a3c9 
…e app home screen
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 7, 2023
@PuBHARGAVI
chore(mosip#607): [Bhargavi] add the comments for profile screen hide…
cbca1d4 
…d labels
@PuBHARGAVI
Copy link
Contributor

PuBHARGAVI commented Mar 8, 2023 •
edited
Loading

  • I made changes in the profile screen and now screen looks like this

Screenshot 2023-03-08 at 12 35 41 PM

  • Changed the default value of VCLabel from "ID" to "Card"

Screenshot 2023-03-08 at 12 38 01 PM

  • Also changed the screen header title from profile to settings in all the languages using goggle translator

Points to be discussed:

  1. when translating "settings" into all the languages i have again retranslated them into english to check if they are coming correct or not. After retranslating also i am getting "settings" in english

  2. For filipino language the translation for "Home" was missing in fil.json file. so i have used google translator to get the equivalent word in filipino language and it showed "Bahay" and when i again retranslated it to english it showed "House"

  3. For the scan screen title "scan" google translator showed "scan" in the filipino language. so as it is same in both english and filipino i didn't change anything for scan screen

  4. In the Home screen for every vc we are displaying title "ID type" above the "National Card" and this value is hardcoded in the code and it is not using the value of vcLabel. Do i have to change this to "Card type" or it should remain "ID type"?
    @nayakrounak @SwatiPeriwal could you please check this?

@SwatiPeriwal
Copy link

@PuBHARGAVI For point no. 4, lets wait for @nayakrounak to revert. On the settings page, any specific reason for us to have "Log-out" instead of "Logout"?

@PuBHARGAVI
Copy link
Contributor

Regarding the 4th point in the above comment :
Currently the "ID type" for every card in the home screen is getting translated in all languages and it is an hardcoded value in the code
Case1:
if i need to change this to "Card type" i need to change this in all the languages json files.
Case2:
I can also replace this hardcoded one with the {VcLabel} but this value is not getting translated in all the languages it shows "Card" irrespective of what language is choosen

@krishnakumar4a4
Copy link
Contributor

@PuBHARGAVI Here is the summary of discussion with @nayakrounak

  1. Move Powered By BLE to lower most area (where version details are present) and remove it from settings options
  2. "ID type" change are not required
  3. Change "Log-out" to "Logout"

Please re-verify for any grammatical errors on all pages for new and existing labels.

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 8, 2023
@PuBHARGAVI
Revert "refactor(mosip#607): [Bhargavi] change the Id type to card ty…
ac31632 
…pe in the app home screen"

This reverts commit 5d6a3c9.
@PuBHARGAVI
Copy link
Contributor

@nayakrounak @krishnakumar4a4 for "Powered by BLE" and "powered by GoogleNearby" the translations were not written for all langauges

This is the en.json file code:
{
"useBle": "Powered by BLE",
"useGoogleNearby": "Powered by GoogleNearby"
}
but this is not written for other languages. So when we select other languages except english it is displaying 'useBle' in the UI

this is for english language:
Screenshot 2023-03-08 at 10 16 04 PM
For other langauges:
Screenshot 2023-03-08 at 10 15 56 PM
95a7ef64.png)

do i have to write translations in all languages?

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 8, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] change the log-out label to Logout in…
d2f3241 
… all the languages in settings screen
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 8, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] remove the powered by BLE from list o…
ed9362c 
…ptions and show it in the bottom in settings
@krishnakumar4a4
Copy link
Contributor

@PuBHARGAVI Irrespective whether translations existed. We should not show useBle in the UI since its not a value but a key.
Having said that, We can keep english names on all languages -> "Powered by BLE" and "Powered by GoogleNearby"

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 9, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] add powered by BLE and powered by Goo…
2bda456 
…gleNearby values in all languages
@PuBHARGAVI
Copy link
Contributor

PuBHARGAVI commented Mar 9, 2023 •
edited by krishnakumar4a4
Loading

Changes made in this task:

  • The profile icon to settings icon
  • Hidden RevokeId, Vc Label, Unlock auth Factor and credits and legal notices option in settings screen
  • Moved the Powered By BLE text from setting options to the bottom in settings screen and added english text in all languages as discussed
  • Log-out to Logout in all languages
  • The Sharing Vc screen labels to "Share" and "Share with Selfie" in all languages
  • Default value of VC Label to "Card"
  • Added translations for Home screen header title in filipino language

Settings Screen looks like this:
Screenshot 2023-03-09 at 1 14 00 PM

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 9, 2023
@PuBHARGAVI
chore(mosip#607): [Bhargavi] change hided to hidden in the comments
2313dd2
krishnakumar4a4 added a commit to tw-mosip/inji-wallet that referenced this issue Mar 9, 2023
@krishnakumar4a4
Merge pull request #16 from ravikp/change-profile-screen-UI
faa7d5a 
mosip#607 Change profile screen and minor UI enhancements
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 9, 2023
@PuBHARGAVI
refactor(mosip#607): [Bhargavi] add translation for Home screen heade…
8526039 
…r title in filipino language
@krishnakumar4a4 krishnakumar4a4 mentioned this issue Mar 9, 2023
Merged
@vharsh
Copy link
Member

vharsh commented Mar 9, 2023

Profile icon has been changed to Settings, & all requested changes are done as per the above comment.

PR for mosip/inji: #630

The PRs have been merged in 09-03-2023 Release and the latest commit id on mosip/inji/develop is fa142c6

@Sujithbn Sujithbn assigned Anushree09-N and unassigned Sujithbn Mar 9, 2023
@Anuranjan14
Copy link

Profile icon has been updated to "SETTINGS" with all the expected changes. Attaching the screenshot for the reference
image

@Anuranjan14 Anuranjan14 assigned Sujithbn and unassigned Anushree09-N Mar 23, 2023
@santhoshsunder santhoshsunder added bug Something isn't working and removed bug Something isn't working labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sujithbn Sujithbn

Labels
MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Projects
MOSIP Inji issues tracking
Status: QA (test)
Milestone
10th MAR 23
Development

No branches or pull requests
10 participants
@ravikp @vharsh @krishnakumar4a4 @nayakrounak @PuBHARGAVI @Anushree09-N @SwatiPeriwal @santhoshsunder @Sujithbn @Anuranjan14