Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared lock #250

Open
wants to merge 93 commits into
base: main
Choose a base branch
from
Open

Shared lock #250

wants to merge 93 commits into from

Conversation

knighton
Copy link
Contributor

@knighton knighton commented Apr 29, 2023

Description of changes:

Implement a shared lock.

  • 25x faster than FileLock
  • No filesystem cleanup afterward
  • Lives in a few bytes of shared memory
  • Uses pthread_mutexattr_setpshared

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

knighton and others added 30 commits April 6, 2023 13:20
This is beacuse we use it in StreamingDataset init for coordinating ranks.
Also add a reference to its contained builtin SharedMemory's buf so it can be used as a drop-in
replacement.
- use cache_limit argument
- cache_usage int64 in shared memory
- shard access times in shared memory
- shard get_raw/zip/full/persistent_size
- StreamingDataset._evict_shard
- StreamingDataset._evict_coldest_shard
- rewrite StreamingDataset._download_shard
- Stream.safe_keep_zip (with local vs remote check)
Base automatically changed from james/evict to main May 25, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant