Refactor MLflow register_model
#1545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleans up the code a little and prevents us from having forked logic in Composer to fetch by run_id
…cleans up the code a little and prevents us from having forked logic in Composer to fetch by run_id
dakinggg
reviewed
Sep 24, 2024
| @@ -128,7 +128,7 @@ def _register_model_with_run_id_multiprocess( | |||
| logging.getLogger('composer').setLevel(composer_logging_level) | |||
|
|
|||
| # Register model. | |||
| mlflow_logger.register_model_with_run_id( | |||
| mlflow_logger.register_model( | |||
There was a problem hiding this comment.
we call this API because otherwise the run id doesn't get properly attached to the registered model, not because of retries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using some hacky logic in Composer to add retry logic to MLflow model registration. Now that MLflow has baked this into their
register_modelAPI, we can call that instead.