Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register mosaic logger #1542

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Register mosaic logger #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
450e8e8
add mosaic logger to registered
dakinggg Sep 23, 2024
623772d
add mosaicml logger direct creation support
dakinggg Sep 23, 2024
82d443b
pc
dakinggg Sep 23, 2024
8537a6c
pc
dakinggg Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llmfoundry/loggers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from composer.loggers import (
InMemoryLogger,
MLFlowLogger,
MosaicMLLogger,
TensorboardLogger,
WandBLogger,
)
Expand All @@ -18,3 +19,4 @@
func=InMemoryLogger,
) # for backwards compatibility
loggers.register('mlflow', func=MLFlowLogger)
loggers.register('mosaicml', func=MosaicMLLogger)
16 changes: 16 additions & 0 deletions tests/loggers/test_mosaic_ml_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2024 MosaicML LLM Foundry authors
# SPDX-License-Identifier: Apache-2.0

from composer.loggers import MosaicMLLogger

from llmfoundry.utils.builders import build_logger


def test_mosaic_ml_logger_constructs():
mosaic_ml_logger = build_logger(
'mosaicml',
kwargs={'ignore_exceptions': True},
)

assert isinstance(mosaic_ml_logger, MosaicMLLogger)
assert mosaic_ml_logger.ignore_exceptions == True
Loading