Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ICL tasks not required for eval #1540

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Make ICL tasks not required for eval #1540

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f91dd
yo
snarayan21 Sep 22, 2024
3db2bf4
yo
snarayan21 Sep 22, 2024
54f1232
replace
snarayan21 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llmfoundry/command_utils/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def evaluate(cfg: DictConfig) -> tuple[list[Trainer], pd.DataFrame]:
EvalConfig,
EVAL_CONFIG_KEYS,
transforms=[allow_toplevel_keys],
icl_tasks_required=True,
icl_tasks_required=False,
)

model_configs = eval_config.models
Expand All @@ -273,7 +273,7 @@ def evaluate(cfg: DictConfig) -> tuple[list[Trainer], pd.DataFrame]:
# Mandatory Evaluation Parameters
icl_tasks = eval_config.icl_tasks or eval_config.icl_tasks_str
if icl_tasks is None:
raise ValueError('icl_tasks must be specified in the config')
icl_tasks = []

# Optional Evaluation Parameters with default values
eval_loader_config = eval_config.eval_loader or eval_config.eval_loaders
Expand Down
Loading