Skip to content

Commit

Permalink
Make ICL tasks not required for eval (#1540)
Browse files Browse the repository at this point in the history
  • Loading branch information
snarayan21 committed Sep 23, 2024
1 parent 14cff66 commit a2c0507
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions llmfoundry/command_utils/eval.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def evaluate(cfg: DictConfig) -> tuple[list[Trainer], pd.DataFrame]:
EvalConfig,
EVAL_CONFIG_KEYS,
transforms=[allow_toplevel_keys],
icl_tasks_required=True,
icl_tasks_required=False,
)

model_configs = eval_config.models
Expand All @@ -273,7 +273,7 @@ def evaluate(cfg: DictConfig) -> tuple[list[Trainer], pd.DataFrame]:
# Mandatory Evaluation Parameters
icl_tasks = eval_config.icl_tasks or eval_config.icl_tasks_str
if icl_tasks is None:
raise ValueError('icl_tasks must be specified in the config')
icl_tasks = []

# Optional Evaluation Parameters with default values
eval_loader_config = eval_config.eval_loader or eval_config.eval_loaders
Expand Down

0 comments on commit a2c0507

Please sign in to comment.