From 893f398b348402015d0b69da88d23fe79972cf15 Mon Sep 17 00:00:00 2001 From: Mihir Patel Date: Mon, 16 Sep 2024 10:38:09 -0700 Subject: [PATCH 1/2] Update error message for overwrite to be more user friendly (#3619) --- composer/utils/remote_uploader.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/composer/utils/remote_uploader.py b/composer/utils/remote_uploader.py index 33793e7c91..da8b2da3dc 100644 --- a/composer/utils/remote_uploader.py +++ b/composer/utils/remote_uploader.py @@ -92,7 +92,10 @@ def upload_file(retry_index: int = 0): # Good! It shouldn't exist. pass else: - raise FileExistsError(f'Object {remote_file_name} already exists, but overwrite was set to False.') + raise FileExistsError( + f'Object {remote_file_name} already exists, but overwrite was set to False. ' + 'Please set `save_overwrite` to `True` in Trainer to overwrite the existing file.', + ) log.info(f'Uploading file {local_file_path} to {remote_file_name}') object_store.upload_object( object_name=remote_file_name, From 129dcbe4d2aef094b8b9a9d61a9fa2a3f0476995 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 19 Sep 2024 22:21:00 +0000 Subject: [PATCH 2/2] Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19 (#3615) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saaketh Narayan Co-authored-by: Mihir Patel --- setup.py | 2 +- tests/loggers/test_wandb_logger.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index befb663b98..6cc65702a7 100644 --- a/setup.py +++ b/setup.py @@ -160,7 +160,7 @@ def package_files(prefix: str, directory: str, extension: str): ] extra_deps['wandb'] = [ - 'wandb>=0.13.2,<0.18', + 'wandb>=0.13.2,<0.19', ] extra_deps['comet_ml'] = [ diff --git a/tests/loggers/test_wandb_logger.py b/tests/loggers/test_wandb_logger.py index e190e39663..b0462fc842 100644 --- a/tests/loggers/test_wandb_logger.py +++ b/tests/loggers/test_wandb_logger.py @@ -269,10 +269,10 @@ def test_wandb_log_metrics(test_wandb_logger): eval_metrics_cross_entropy_count = all_run_text.count('metrics/eval/CrossEntropy') train_loss_count = all_run_text.count('loss/train/total') - expected_number_train_loss_count = (dataset_size / batch_size) + 1 # wandb includes it in the file one extra time + expected_number_train_loss_count = (dataset_size / batch_size) * 2 # wandb includes it twice per step expected_number_train_metrics_count = ( dataset_size / batch_size - ) + 2 # wandb includes it in the file two extra times + ) * 2 + 2 # wandb includes it twice per step plus two extra times expected_number_eval_metrics_count = 2 # wandb includes it in the file twice assert train_metrics_accuracy_count == expected_number_train_metrics_count assert train_loss_count == expected_number_train_loss_count