Rename DelegationTokenStorage #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-morpho
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
colin-morpho
changed the title
MathisGD
previously approved these changes
Oct 23, 2024
MerlinEgalite
previously approved these changes
Oct 23, 2024
QGarchery
previously approved these changes
Oct 23, 2024
colin-morpho
dismissed stale reviews from QGarchery, MerlinEgalite, and MathisGD
via
3357c9a
QGarchery
approved these changes
Oct 23, 2024
MerlinEgalite
approved these changes
Oct 23, 2024
Jean-Grimal
requested changes
Oct 23, 2024
| 0xd583ef41af40c9ecf9cd08176e1b50741710eaecf057b22e93a6b99fa47a6400; | ||
|
|
||
| /* STORAGE LAYOUT */ | ||
|
|
||
| /// @custom:storage-location erc7201:DelegationToken | ||
| struct ERC20DelegatesStorage { | ||
| struct DelegationTokenStorage { |
There was a problem hiding this comment.
As this storage is only about delegation
Suggested change
| struct DelegationTokenStorage { | |
| struct DelegationStorage { |
Or we can just do like OZ and stay with the exact contract name.
There was a problem hiding this comment.
It matches the name of the contract though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, we rename the
DelegationTokenstorage.