Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint/burn ethereum #44

Merged
merged 27 commits into from
Oct 22, 2024
Merged

Conversation

MerlinEgalite
Copy link
Contributor

No description provided.

@QGarchery QGarchery mentioned this pull request Oct 22, 2024
QGarchery
QGarchery previously approved these changes Oct 22, 2024
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving if #45 is merged

MathisGD

This comment was marked as outdated.

@MathisGD MathisGD changed the base branch from feat/optimism-morpho-token to main October 22, 2024 19:08
@MathisGD MathisGD dismissed stale reviews from QGarchery and themself October 22, 2024 19:08

The base branch was changed.

@MathisGD MathisGD changed the base branch from main to feat/optimism-morpho-token October 22, 2024 19:08
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Review fixes on top of optimism+mint/burn
@MathisGD MathisGD merged commit d827768 into feat/optimism-morpho-token Oct 22, 2024
2 checks passed
@MathisGD MathisGD deleted the feat/mint-burn-ethereum branch October 22, 2024 19:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably rename this file to MorphoTokenEthereum.sol

Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants