Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis template uses jobs: which overrides any existing matrix: #95

Open
jayvdb opened this issue Jul 9, 2019 · 1 comment
Open

travis template uses jobs: which overrides any existing matrix: #95

jayvdb opened this issue Jul 9, 2019 · 1 comment

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 9, 2019

The addition of jobs: in 1650163 breaks any use of matrix: which appeared inside blocks test_other_environments, exclusion_matrix and extra_matrix

e.g. the moban repo https://github.com/moremoban/moban/blob/dev/.moban.d/travis.yml used extra_matrix to check MINREQ=1, but this was silently dropped at moremoban/moban@ac56511 (moremoban/moban#272) because jobs: overrides the matrix:

I am fairly sure that @pyexcel used those blocks also.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 14, 2019

This isnt easily solved here, as anything could be in extra_matrix.

This can be resolved by fixing any use of extra_matrix after #100 , so that the custom templates use either jobs or extra_jobs if they were using extra_matrix to contain job matrix entries.

And then deprecate extra_matrix or change its docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant