Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base, sql, and telemetry from moovfinancial/go-observability #336

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

adamdecaf
Copy link
Member

No description provided.

InfernoJJ
InfernoJJ previously approved these changes Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (f9148cd) 76.78% compared to head (a7de58a) 78.40%.
Report is 12 commits behind head on master.

❗ Current head a7de58a differs from pull request most recent head a845795. Consider uploading reports for the commit a845795 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   76.78%   78.40%   +1.61%     
==========================================
  Files          28       42      +14     
  Lines        1034     1690     +656     
==========================================
+ Hits          794     1325     +531     
- Misses        178      286     +108     
- Partials       62       79      +17     
Files Coverage Δ
log/model_valuer.go 100.00% <100.00%> (ø)
telemetry/stdout.go 100.00% <100.00%> (ø)
telemetry/honey.go 87.50% <87.50%> (ø)
telemetry/collector.go 66.66% <66.66%> (ø)
telemetry/env.go 40.00% <40.00%> (ø)
sql/sql.go 94.36% <94.36%> (ø)
telemetry/exporter.go 87.09% <87.09%> (ø)
sql/db.go 93.93% <93.93%> (ø)
sql/tx.go 92.10% <92.10%> (ø)
telemetry/attributes.go 94.69% <94.69%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf merged commit 159af5d into moov-io:master Nov 3, 2023
8 checks passed
@adamdecaf adamdecaf deleted the copy-from-observability branch November 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants