Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FamixDeprecatedSlot still needed ? #2537

Open
NicolasAnquetil opened this issue Aug 25, 2024 · 2 comments
Open

FamixDeprecatedSlot still needed ? #2537

NicolasAnquetil opened this issue Aug 25, 2024 · 2 comments
Assignees

Comments

@NicolasAnquetil
Copy link
Contributor

We could remove it may be ?

Or rename it ?
(comment: "I am a slot used when the usage of an instance variable should be deprecated.")

@jecisc
Copy link
Member

jecisc commented Aug 26, 2024

It's currently not used but it could have its usage in the future.

We used it for example when we removed some relations but the users could use the relations in their own subclasses. To not break everything we used the deprecated slot to keep them.

I don't have a strong opinion on keeping or removing them. @ClotildeToullec any opinion?

@ClotildeToullec
Copy link
Member

No strong opinion either.

The fact that it is not currently used is not really relevant in itself; it's not often used by design.
However it should be removed if we never use it.

How would you rename it Nicolas?
Maybe a better comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants