Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Use node-webrtc #8

Open
ekmartin opened this issue May 2, 2015 · 4 comments
Open

Use node-webrtc #8

ekmartin opened this issue May 2, 2015 · 4 comments

Comments

@ekmartin
Copy link
Member

ekmartin commented May 2, 2015

Wouldn't it make more sense to use node-webrtc for the webrtc-swarm to avoid having to use electron-spawn to run the bot?

Example from webrtc-swarm:

var sw = swarm(hub, {
  wrtc: wrtc
})

Or am I missing something crucial?

@ungoldman
Copy link
Member

@ekmartin I'm not sure but I think @mafintosh said we need the electron environment to get around some wrtc issues right now. Otherwise I'm all for it.

@mafintosh can you comment?

@Flet
Copy link
Member

Flet commented May 2, 2015

I believe @maxogden saw some cpu leakage
node-webrtc/node-webrtc#201

@beaugunderson
Copy link
Member

there was runaway CPU after an hour, but runaway CPU also happened after an hour under xvfb-run electron-spawn peerbot.js

i just checked my debug-compiled electron/libchromiumcontent and it's also using constant 70% cpu, i'll gather some perf data and report back

@beaugunderson
Copy link
Member

more background info

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants