feat: Add Guide menu to on-screen virtual controller
#1265
Conversation
In order to allow the `Guide Button` to be pressed without a physical gamepad, add the button to the On-screen virtual controller
With the addition of the `guide menu` to the on screen virtual controller. A configuration to allow hiding it is not present
|
I am really looking forward to it as it will be a game changer for those using the app to connect to Batocera OS where the button acts like hotkey for several functionality. |
There was a problem hiding this comment.
@mattvgm I am the maintainer of Sunshine and getting more involved in the Moonlight side. I'm trying to help out by completing some pre-reviews before they go to cgutman.
This seems good to me. I am going to test these changes later, but for now I have a few code style nit picks.
...ava/com/limelight/binding/input/virtual_controller/VirtualControllerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
...ava/com/limelight/binding/input/virtual_controller/VirtualControllerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
...ava/com/limelight/binding/input/virtual_controller/VirtualControllerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
…er/VirtualControllerConfigurationLoader.java Co-authored-by: ReenigneArcher <[email protected]>
…er/VirtualControllerConfigurationLoader.java Co-authored-by: ReenigneArcher <[email protected]>
…er/VirtualControllerConfigurationLoader.java Co-authored-by: ReenigneArcher <[email protected]>
|
@ReenigneArcher Thank you for the feedback and thank you for the Sunshine project, is a fantastic project. I agree with all the changes to keep the code consistence. I'll be around for anything, thanks |
There was a problem hiding this comment.
I tested the changes and everything works as expected.
I do have one question, since I am new to this codebase, which is regarding the translations. #1314 (comment)
Description
In some games/applications the
guide menu(or Xbox button) is actually important, for example when usingSteam Big Picturethis button opens the big picture's menu to tweak controller,exit game, etc...This PR adds to the On-screen virtual controller the
Guide Menu(The name can be changed) between theSTARTandBACKbuttons.It also adds a configuration for the ones that want to hide it and don't need to use it.
Motivation
Personally this helps me 100% as my second generic gamepad does not have this button and I have other combos mapped to
BACK + START.I would even add a configuration to only have this button, but I think maybe the PR #1247 already address it in a good way.Tested with both #1247 and #1171 and works perfectly, no conflicts and made my experience better
Screenshot