Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send report csv as attachment #55

Open
hamishdewe opened this issue May 14, 2019 · 4 comments
Open

Send report csv as attachment #55

hamishdewe opened this issue May 14, 2019 · 4 comments

Comments

@hamishdewe
Copy link

We want to be able to send data to users in a format that allows them to do their own filtering. Requiring them to log in to download the csv adds extra overhead to the task, so we want to attach the csv to the notification that they get sent.

@hamishdewe hamishdewe mentioned this issue May 15, 2019
@frumbert
Copy link

Is this feature still being considered?

@timhunt
Copy link
Member

timhunt commented Jun 28, 2020

Can the Moodle message API handle attachments? If so, this would be a nice feature. Up-to-date pull requests welcome.

@Kemmotar83
Copy link

Hi Tim,

this plugin is great and implementing this feature could be very useful (in our university I would say necessary).

We have read the discussion made in the pull request #86 and, since the Message API still does not support temp files, I would say that the only solution is to use a Stored File.

Starting from that, we implemented the feature, paying attention to have all your automated tests working.
Before submitting a pull requests, we would like to know if you are still interested in this feature and then we would like to discuss with you about some implementation details (i.e. user private storage area vs plugin storage area).

Giorgio

@timhunt
Copy link
Member

timhunt commented Mar 24, 2022

Thank you for considering contributing to this plugin.

I note that pull request #86 has been sitting around for over 2 years. If, 2 years ago, someone had made a change to Moodle core so that the file API could send temp files, then there would not be an issue any more.

On the other hand, just having the files sitting around in moodledate, but not in filedir, causes problems with some ways of setting up cloud hosting, so I am no longer so opposed to saving the reports with the file API, if that is implemented nicely.

I think that the key part of working out how to implement this is deciding exactly how things will be stored. Do you have a plan for how you will do it? It would be good to agree on that before you start writing code.

Thanks. Tim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants