From 6d83352561441febecdd263a5d4d56cc44eb109c Mon Sep 17 00:00:00 2001 From: Daniel Ziegenberg Date: Thu, 19 Sep 2024 12:45:51 +0200 Subject: [PATCH] Add test for multiline attributes for MissingDocblockSniff on methods outside of classes --- .../Commenting/MissingDocblockSniffTest.php | 9 ++++---- .../docblock_with_multiline_attributes.php | 21 +++++++++++++++++++ 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php b/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php index 22bf815..5c39732 100644 --- a/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php +++ b/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php @@ -231,10 +231,11 @@ public static function docblockCorrectnessProvider(): array { 'fixture' => 'docblock_with_multiline_attributes', 'fixtureFilename' => null, 'errors' => [ - 59 => 'Missing docblock for class class_multiline_attribute_space_between', - 69 => 'Missing docblock for function method_multiline_attribute_space_between', - 81 => 'Missing docblock for interface interface_multiline_attribute_space_between', - 92 => 'Missing docblock for trait trait_multiline_attribute_space_between', + 69 => 'Missing docblock for class class_multiline_attribute_space_between', + 79 => 'Missing docblock for function method_multiline_attribute_space_between', + 91 => 'Missing docblock for function single_method_multiline_attribute_space_between', + 102 => 'Missing docblock for interface interface_multiline_attribute_space_between', + 113 => 'Missing docblock for trait trait_multiline_attribute_space_between', ], 'warnings' => [], ]; diff --git a/moodle/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php b/moodle/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php index f516255..2924b06 100644 --- a/moodle/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php +++ b/moodle/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php @@ -28,6 +28,16 @@ function method_multiline_attribute(): void { } } +/* + * Function with multiline attributes. + */ +#[someattribute( + attr1: 'asdf', + attr2: 'asdf', +)] +function single_method_multiline_attribute(): void { +} + /** * Interface with multiline attributes. */ @@ -70,6 +80,17 @@ function method_multiline_attribute_space_between(): void { } } +/* + * Function with multiline attributes and space between. + */ + +#[someattribute( + attr1: 'asdf', + attr2: 'asdf', +)] +function single_method_multiline_attribute_space_between(): void { +} + /** * Interface with multiline attributes. */