Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the runner able to rebase any dev branch on top of upstream ones, so can run current code #58

Open
stronk7 opened this issue Aug 12, 2021 · 0 comments

Comments

@stronk7
Copy link
Member

stronk7 commented Aug 12, 2021

Right now all the ci-runner jobs are run against the development branch "as is".

If such development branch has not been rebased recently against upstream branches, everything can look correct, with jobs passing.

And only when the issue is integrated is when the problems are discovered:

  • conflicts on merge.
  • tests using old stuff.
  • grunt generated stuff needing to be amended.
  • other failures caused by changes in upstream branches.
  • ...

So the idea is to:

  1. Add a new optional env variable to control when the the jobs must be run with candidate branches (default, current behavior) or with the candidate branches rebased against their corresponding upstream branches.
  2. Decide which jobs will run each type of run. For example, surely all the "post" (after integration) jobs, don't need this feature, they are already "upstream". But all the "pre" jobs (before integration) surely will benefit from this enormously, detecting conflicts, missing grunt stuff and other failures in advance.

That's the idea, so far, ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant