Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER-80231: Add conditional statement for variable declaration #1560

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

siddux
Copy link

@siddux siddux commented Jul 10, 2023

The changes solve the minor issue reported here.

Copy link

@suenalaba suenalaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, some comments

src/mongo/util/net/sock.h Outdated Show resolved Hide resolved
src/mongo/util/net/sock.h Outdated Show resolved Hide resolved
@siddux
Copy link
Author

siddux commented Aug 17, 2023

Thanks for your comments

@kelly-cs
Copy link
Contributor

Thanks for making this pull request! We just need you to create a new SERVER ticket on JIRA to help us track the PR. Linking https://jira.mongodb.org/browse/CXX-2708 will be great too.

@kelly-cs kelly-cs changed the title Add conditional statement for variable declaration SERVER-80231: Add conditional statement for variable declaration Aug 18, 2023
@kelly-cs
Copy link
Contributor

We're changed the existing ticket to SERVER-80231 (originally CXX-2708) to track this work, so no need to make a new ticket.

@suenalaba
Copy link

Thanks for your comments

Please fix he typos and recommit

@siddux
Copy link
Author

siddux commented Sep 4, 2023

Thanks for your comments

Please fix he typos and recommit

Just fixed.

Copy link

@suenalaba suenalaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants