Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4602: Add feature flag to conditionally show WIP locales #1052

Merged
merged 1 commit into from
May 31, 2024
Merged

DOP-4602: Add feature flag to conditionally show WIP locales #1052

merged 1 commit into from
May 31, 2024

Conversation

rayangler
Copy link
Contributor

@rayangler rayangler commented May 30, 2024 •
edited
Loading

Stories/Links:

DOP-4602

Notes

  • This adds a new feature flag to conditionally show specific locales in the frontend. The original intention was to have it specifically for Japanese, but I pre-emptively made it more generalized in case we need to reuse it for different languages.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@rayangler rayangler changed the title DOP-4602: Add feature flag to hide WIP locales DOP-4602: Add feature flag to conditionally show WIP locales May 30, 2024
branberry
branberry approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://hjudhybxa1.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

@rayangler rayangler merged commit 5755558 into main May 31, 2024
7 checks passed
@rayangler rayangler deleted the DOP-4602 branch May 31, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branberry branberry branberry approved these changes

@mmeigs mmeigs mmeigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayangler @branberry @mmeigs