-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-43936-mongosh-multiple-connections #672
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just leaving a small formatting suggestion which you can take or leave. Thanks @ltran-mdb2!
source/embedded-shell.txt
Outdated
To open the embedded :binary:`mongosh`, click :guilabel:`>_` on the | ||
right of your deployment name in the :guilabel:`Connections Sidebar` or | ||
click :guilabel:`>_Open MongoDB Shell` in the top right of the | ||
:guilabel:`Databases` tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional suggestion]
To make this a bit more scannable, we could consider making these bullets. As in:
To open the embedded :binary:`mongosh`, you can either:
- Click :guilabel:`>_` on the right of your deployment name in the :guilabel:`Connections Sidebar`.
- Click :guilabel:`>_Open MongoDB Shell` in the top right of the :guilabel:`Databases` tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched these lines to bullets! Thanks!
source/embedded-shell.txt
Outdated
- Click :guilabel:`>_Open MongoDB Shell` in the top right of the | ||
:guilabel:`Databases` tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually click this button in any connection-specific tab, and the button has "shell" written in lowercase. Thanks Lauren!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "connection window" is the best way to describe this location since an application window is different from a tab. What would you think of rewording this bullet to the following?
Click
>_Open MongoDB shell
in the top right of any tab connected to a MongoDB deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
DESCRIPTION
Adding MongoDB shell touchpoint
STAGING
https://deploy-preview-672--docs-compass.netlify.app/embedded-shell/#open-the-embedded-mongodb-shell
JIRA
https://jira.mongodb.org/browse/DOCSP-43936
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?