Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please use semantic versioning #102

Open
tubbo opened this issue Oct 28, 2022 · 1 comment
Open

please use semantic versioning #102

tubbo opened this issue Oct 28, 2022 · 1 comment

Comments

@tubbo
Copy link

tubbo commented Oct 28, 2022

i have to ignore this package from automatic updates because it doesn't use semver, so if you are going to update it I'd appreciate if you stuck to the same scheme that every other package in the entire world uses, including other packages from this organization. Since the package didn't communicate that it was locked into Mongoose v6 (had to look back in the changelog for several versions), it broke a ton of tests for really weird reasons that took a while to figure out.

On the other hand, we're actually trying to remove all usage of this package in our codebase since it's so dangerous to use. It's especially alluring to inexperienced programmers who don't want to have to type populate() all the time, but at scale it creates a ton of performance problems that end up resulting in removal of the plugin entirely. So if you don't want to maintain it anymore, I would also advocate for archival and a note saying "please stop using this".

@vkarpov15
Copy link
Member

Why exactly does this package not use semver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants