Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/cache: ^1.0|^2.0|^3.0 #771

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

umpirsky
Copy link
Contributor

No description provided.

@frederikbosch
Copy link
Member

This is great. I don't see any reason not to merge this.

@frederikbosch
Copy link
Member

Well, why did you went from ^1.0.1 to ^1.0. And why did we use ^1.0.1 to begin with. I don't have time to look into this history, not right now. Do you know why that might have been done? And why did you allow 1.0.0? Maybe ^1.0.1 || ^2.0 || ^3.0 is safer.

@umpirsky
Copy link
Contributor Author

Whatever you prefer. I just want to allow 2.0 since 1.0.1 is released 8 years ago.

@frederikbosch
Copy link
Member

Let's go for ^1.0.1 || ^2.0 || ^3.0, then I'll merge.

@umpirsky
Copy link
Contributor Author

Done.

@frederikbosch frederikbosch merged commit 0d2d561 into moneyphp:master Jan 11, 2024
9 checks passed
@frederikbosch
Copy link
Member

I will create a tag for this this week.

@umpirsky umpirsky deleted the psr2 branch January 11, 2024 12:04
@frederikbosch
Copy link
Member

Thanks for the work!

@umpirsky
Copy link
Contributor Author

Thanks for merging that fast. 👍

@umpirsky
Copy link
Contributor Author

@frederikbosch Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants