Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Add option for for log directory #903

Closed
Wuodan opened this issue Jun 13, 2018 · 3 comments
Closed

Add option for for log directory #903

Wuodan opened this issue Jun 13, 2018 · 3 comments

Comments

@Wuodan
Copy link
Contributor

Wuodan commented Jun 13, 2018


By submitting this issue, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

By default, kovri writes logs to the directory ~/.kovri/log in form of a file per day.
One can specify an alternative path with --log-file-name, but that will always be the same file name.

I would like the possibility to specify a folder path, where a log file per day is created.

Possible solutions:
a) Rename --log-file-name to --log-path. If it's a file, write to that file. If it's a folder, create a file per day there.
b) An additional option --log-folder. Incompatible with --log-file-name.
(These are just ideas!!)

@coneiric
Copy link
Contributor

An additional option --log-folder. Incompatible with --log-file-name.

Just speaking for myself, two command-line options seem like a better solution. That way a user can specify custom directory and filename independently.

Why would the two options need to be incompatible?

@anonimal
Copy link
Collaborator

Why would the two options need to be incompatible?

Because a filename could contain a path. I personally wouldn't bother with the work involved to sanitize filename and instead would opt for a single --log-dir option.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants