Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Use Boost.Log #33

Closed
anonimal opened this issue Nov 20, 2015 · 7 comments
Closed

Use Boost.Log #33

anonimal opened this issue Nov 20, 2015 · 7 comments
Assignees
@anonimal
Labels
enhancement major

Comments

@anonimal
Copy link
Collaborator

@majestrate expressed an interest in moving on this. I think its an essential idea but needs more research. See http://www.boost.org/doc/libs/1_59_0/libs/log/doc/html/log/rationale/fork_support.html
@anonimal
Copy link
Collaborator Author

In a normal world, this would be a minor enhancement. In Kovri's world, nothing is minor 😅

@anonimal
Copy link
Collaborator Author

See #40

@anonimal anonimal mentioned this issue Dec 3, 2015
Closed
@anonimal
Copy link
Collaborator Author

Latest related commit: a94af0c
@majestrate, what else needs to be done in order to close this ticket?

@majestrate
Copy link
Contributor

more testing of the code

@anonimal anonimal mentioned this issue Dec 13, 2015
Closed
@anonimal
Copy link
Collaborator Author

@majestrate should we write tests? And any thoughts on how we can swing this with #53?

@majestrate
Copy link
Contributor

unit tests are a must

@anonimal anonimal mentioned this issue Dec 19, 2015
Closed
@anonimal
Copy link
Collaborator Author

anonimal commented Jan 3, 2016

Also, removal of deprecated log code.

@anonimal anonimal mentioned this issue Jan 27, 2016
Merged
@anonimal anonimal self-assigned this Feb 14, 2016
anonimal added a commit to anonimal/kovri that referenced this issue Jun 15, 2016
@anonimal
Log: finish pimpl refactor. Refs monero-project#33.
ed94a21 
Also:
* Style refactor
* Remove unused code
* Document remaining code / add important notes
@anonimal anonimal mentioned this issue Jun 18, 2016
Merged
1 task
anonimal added a commit that referenced this issue Jun 19, 2016
@anonimal
Merge pull request #202
425ff5e 
4151d77 Log: fix trivial typo. (anonimal)
456d718 Kovri: s/Warning/Warn/g for consistency with Log. (anonimal)
20b4f27 Log: implement log-levels runtime capability. (anonimal)
7906dfc Daemon: minor log member style refactor. (anonimal)
ba5fc9e Log: improve/cleanup stream formatting. (anonimal)
8334124 Log: C++11/14 refactor of ostream operator<< (anonimal)
093dd65 Log: s/GetLogger/GetLogStream/ in LoggerImpl. (anonimal)
ed94a21 Log: finish pimpl refactor. Refs #33. (anonimal)
anonimal added a commit that referenced this issue Jun 19, 2016
@anonimal
Merge pull request #211
b078bd5 
4151d77 Log: fix trivial typo. (anonimal)
456d718 Kovri: s/Warning/Warn/g for consistency with Log. (anonimal)
20b4f27 Log: implement log-levels runtime capability. (anonimal)
7906dfc Daemon: minor log member style refactor. (anonimal)
ba5fc9e Log: improve/cleanup stream formatting. (anonimal)
8334124 Log: C++11/14 refactor of ostream operator<< (anonimal)
093dd65 Log: s/GetLogger/GetLogStream/ in LoggerImpl. (anonimal)
ed94a21 Log: finish pimpl refactor. Refs #33. (anonimal)
73912f3 Travis: grab Coverity cert manually. Refs travis-ci/travis-ci#6142 (anonimal)
18e7666 Travis: add certs. Refs travis-ci/travis-ci#6142 (anonimal)
48e33bc Travis: attempt to fix Coverity. Refs #199. (anonimal)
@anonimal anonimal closed this as completed Jul 9, 2016
@anonimal anonimal mentioned this issue Jul 9, 2016
Closed
1 task
EinMByte added a commit to EinMByte/kovri that referenced this issue Jul 9, 2016
@EinMByte
Merge pull request #2
dfe19a0 
064442e Reseed: fix literal-suffix warning. Refs monero-project#220. (anonimal)
0ce92bd Reseed: do not rely on [a-z] catching all letters (moneromooo-monero)
6306a8e GetFormattedSessionInfo: revert ca5c48e. (anonimal)
3902502 NTCP/SSU: remove LogPrint from ctors/dtors. (anonimal)
ca5c48e GetFormattedSessionInfo: fix massive memory leak. (anonimal)
8097275 Docs: add 'Proposals' caveat to contributing guide. (anonimal)
4ca5991 Docs: add commit-title caveat to contributing guide. (anonimal)
4151d77 Log: fix trivial typo. (anonimal)
456d718 Kovri: s/Warning/Warn/g for consistency with Log. (anonimal)
20b4f27 Log: implement log-levels runtime capability. (anonimal)
7906dfc Daemon: minor log member style refactor. (anonimal)
ba5fc9e Log: improve/cleanup stream formatting. (anonimal)
8334124 Log: C++11/14 refactor of ostream operator<< (anonimal)
093dd65 Log: s/GetLogger/GetLogStream/ in LoggerImpl. (anonimal)
ed94a21 Log: finish pimpl refactor. Refs monero-project#33. (anonimal)
73912f3 Travis: grab Coverity cert manually. Refs travis-ci/travis-ci#6142 (anonimal)
18e7666 Travis: add certs. Refs travis-ci/travis-ci#6142 (anonimal)
48e33bc Travis: attempt to fix Coverity. Refs monero-project#199. (anonimal)
anonimal added a commit that referenced this issue Jul 14, 2016
@anonimal
Merge pull request #227
301eb3c 
eea4075 Crypto: use constant-time comparison in ed25519. (anonimal)
064442e Reseed: fix literal-suffix warning. Refs #220. (anonimal)
0ce92bd Reseed: do not rely on [a-z] catching all letters (moneromooo-monero)
6306a8e GetFormattedSessionInfo: revert ca5c48e. (anonimal)
3902502 NTCP/SSU: remove LogPrint from ctors/dtors. (anonimal)
ca5c48e GetFormattedSessionInfo: fix massive memory leak. (anonimal)
8097275 Docs: add 'Proposals' caveat to contributing guide. (anonimal)
4ca5991 Docs: add commit-title caveat to contributing guide. (anonimal)
4151d77 Log: fix trivial typo. (anonimal)
456d718 Kovri: s/Warning/Warn/g for consistency with Log. (anonimal)
20b4f27 Log: implement log-levels runtime capability. (anonimal)
7906dfc Daemon: minor log member style refactor. (anonimal)
ba5fc9e Log: improve/cleanup stream formatting. (anonimal)
8334124 Log: C++11/14 refactor of ostream operator<< (anonimal)
093dd65 Log: s/GetLogger/GetLogStream/ in LoggerImpl. (anonimal)
ed94a21 Log: finish pimpl refactor. Refs #33. (anonimal)
@moneromooo moneromooo mentioned this issue Oct 2, 2016
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anonimal anonimal

Labels
enhancement major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majestrate @anonimal