-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "mondo-with-equivalents" and "mondo-minimal" from release #7912
Comments
Here at ClinGenm we've been using the mondo-with-equivs for years. We use it in several projects, you could say it is a critical source of data for us. I saw no such announcement that this file was going away. What is it being replaced with? Is the json schema unchanged in the new file? |
@plweller3 first of all, big apologies for the issues this has caused you. We announced it on the mondo-users mailing list https://groups.google.com/g/mondo-users/c/Q-xuJEvjPxI/m/bwmnd0dOAAAJ and in our Outreach call But we should have checked more specifically with you, @courtneythaxton and @larrybabb, sorry about that! I suggest we follow a three part approach
What do you think? |
In case we cant resolve #7912 we should consider adding it back..
I have added the mondo-to-equivalents variants now back to the release as a one off, but it would be good to proceed to steps 2 and 3 as well.. :) |
After reviewing @plweller3 pipeline, I suggest we do this:
|
A colleague of mine was using mondo-minimal in a GitHub action to create an ontology. He has since left the project, and I am now maintaining that code. I tried switching to using mondo-import, but I'm running out of memory on the GitHub Action VM when running the following robot.jar command:
It seems the memory requirements are very high for this process for some reason (I'm not an expert on what robot.jar is doing with that call), so the ontology used in that call needs to be pretty small, like the size of mondo-minimal. Is it possible to include mondo-minimal back into the release? If not, could you provide guidance on how I could modify the release version of the ontology to contain only what mondo-minimal would contain? FYI, our ontology is hosted here: https://github.com/midas-network/midas-data/ Thanks! |
Hell @JohnLevander! Thanks for providing your issue. Incidentally, I helped setting up the midas data pipeline back then, so I made a PR there and commented on midas-network/midas-data#67. |
We announced the following:
We plan to remove the following ontology variants from future releases (starting with the July release): mondo-with-equivalents ; mondo-minimal. If you use these ontology variants, please let us know as soon as possible!
We have not heard that these ontology variants are in used. We can go ahead and remove them.
The text was updated successfully, but these errors were encountered: