Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we use ontobot to add obsoletion tags to obosoletion candidates in Mondo? #7243

Closed
nicolevasilevsky opened this issue Feb 6, 2024 · 10 comments
Assignees

Comments

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Feb 6, 2024

This is the current workflow:

  1. We receive a request to obsolete a term
  2. A curator reviews the request and manually copies and pastes the following metadata into this ROBOT template spreadsheet
    • Mondo ID
    • Mondo label (this just for human readability)
    • term tracker item
    • Term to consider ID (if applicable)
    • Term to consider label (if applicable)
    • The following fields are concatenated to create a comment: Obsoletion reason (it is always out of scope), exclusion reason, and term to consider (if applicable)
    • Obsoletion candidate subset (http://purl.obolibrary.org/obo/mondo#obsoletion_candidate)
    • Obsoletion data (in the format YYYY-MM-DD)

If we had a standardized template that looked something like this in GitHub, could ontobot apply the relevant metadata to the term?

image

Some of the info could be filled out by the user, but some of the info would need to be supplied by us, like the obsoletion candidate subset. Could ontobot be programmed to add additional info like obsoletion candidate or obsoletion date?

We would also need ontobot to be able to concatenate certain info into a comment, like is done in the spreadsheet in column I.

The metadata would looks something like this:

image
@nicolevasilevsky
Copy link
Member Author

cc @sabrinatoro @twhetzel

@sabrinatoro
Copy link
Collaborator

Specific question to @hrshdhgd

  1. can we have ontobot add the "obsoletion candidate" (as explained above)?
  2. could we use ontobot to create a 2nd PR from the same GH issue to make the actual obsoletion?

@hrshdhgd
Copy link
Member

hrshdhgd commented Feb 6, 2024

Specific question to @hrshdhgd

  1. can we have ontobot add the "obsoletion candidate" (as explained above)?

The obsolete command does work via ontobot-change-agent, example (via BioPortal):

  1. could we use ontobot to create a 2nd PR from the same GH issue to make the actual obsoletion?

No. Each issue is associated with one and only one PR.

@nicolevasilevsky
Copy link
Member Author

@hrshdhgd this is different that adding the is_obsolete: true annotation, this request is to add new annotations, and some of them will be need to be concatenated based on specific input. I'm not sure if ths is possible with ontobot? That is our question.
Thank you!

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Feb 6, 2024

@twhetzel @sabrinatoro - perhaps as an alternative, maybe we could use a sparql query? @matentzn did this sparql in this PR to add new clingen_preferred synonym types

(I'm just brainstorming here! 🤷‍♀️ )

@sabrinatoro
Copy link
Collaborator

@nicolevasilevsky a sparql query for what? The query will report a list of terms, not add anything or do an action.

@nicolevasilevsky
Copy link
Member Author

If you look at that linked PR, I think Nico used SPARQL to add the clingen_preferred tag (maybe I am wrong?)

@sabrinatoro
Copy link
Collaborator

I don't think so (or you cannot tell with the PR), but I think that the SPARQL query gives a list of terms (based on specific criteria), and then there was an action (e.g. someone added a tag to something reported in the query).
But let's ask Nico for clarification.

@cmungall
Copy link
Member

cmungall commented Feb 6, 2024

INCATools/kgcl#49

@twhetzel
Copy link
Collaborator

From what I understand chatting with Harshad is that KGCL can not yet handle adding the kinds of properties that Mondo uses to indicate that a term is an obsoletion candidate so closing this for and will an eye out for INCATools/kgcl#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants