Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in match-mondo-sources-all-lexical.py #390

Closed
matentzn opened this issue Dec 17, 2023 · 4 comments · Fixed by #397
Closed

Bug in match-mondo-sources-all-lexical.py #390

matentzn opened this issue Dec 17, 2023 · 4 comments · Fixed by #397
Assignees
Labels
bug Something isn't working priority

Comments

@matentzn
Copy link
Member

Traceback (most recent call last):
  File "/work/src/ontology/../scripts/match-mondo-sources-all-lexical.py", line 174, in <module>
    main()
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/work/src/ontology/../scripts/match-mondo-sources-all-lexical.py", line 121, in run
    msdf = lexical_index_to_sssom(oi, lexical_index, ruleset=ruleset, meta=meta)
  File "/usr/local/lib/python3.10/dist-packages/oaklib/utilities/lexical/lexical_indexer.py", line 316, in lexical_index_to_sssom
    Converter.from_prefix_map((meta or {}).pop(CURIE_MAP, {})),
AttributeError: 'tuple' object has no attribute 'pop'
make[1]: *** [mondo-ingest.Makefile:432: ../mappings/mondo-sources-all-lexical.sssom.tsv] Error 1
@matentzn matentzn added the bug Something isn't working label Dec 17, 2023
@matentzn
Copy link
Member Author

matentzn commented Jan 4, 2024

After updating all dependencies the issue persists:

Traceback (most recent call last):
  File "/work/src/ontology/../scripts/match-mondo-sources-all-lexical.py", line 174, in <module>
    main()
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/work/src/ontology/../scripts/match-mondo-sources-all-lexical.py", line 121, in run
    msdf = lexical_index_to_sssom(oi, lexical_index, ruleset=ruleset, meta=meta)
  File "/usr/local/lib/python3.10/dist-packages/oaklib/utilities/lexical/lexical_indexer.py", line 316, in lexical_index_to_sssom
    Converter.from_prefix_map((meta or {}).pop(CURIE_MAP, {})),
AttributeError: 'tuple' object has no attribute 'pop'

@matentzn
Copy link
Member Author

matentzn commented Jan 4, 2024

@twhetzel I think this is high priority as we cant run the mondo ingest pipeline at all now. My advice is to have Joe work on this, as he is familiar with both the mondo ingest and oaklib code.

@matentzn matentzn assigned joeflack4 and unassigned hrshdhgd Jan 4, 2024
@joeflack4
Copy link
Contributor

Oh OK, looks like a simple bug to fix. I'll try my best to get in an OAK PR by Monday!

@joeflack4
Copy link
Contributor

joeflack4 commented Jan 7, 2024

@matentzn Just wanting to know more information; how is this being run / what is the command / goal running this?

I think it is the goal: $(MAPPINGSDIR)/mondo-sources-all-lexical.sssom.tsv, and this is just one step that is erroring out as part of you just running the full pipeline, is that correct?

I worked on this a bit today. Most of my time went into fixing my OAK environment, and it looks like that's done.

First I tried to run this script in mondo-ingest and replicate before I went to fix it in OAK, but I got a different error, probably earlier in the script. This is all the time I have for this this weekend but I'll pick up from here next session:

raise DuplicateURIPrefixes(duplicate_uri_prefixes)
curies.api.DuplicateURIPrefixes ...

Do you have any idea what might be causing that?

@joeflack4 joeflack4 linked a pull request Jan 12, 2024 that will close this issue
8 tasks
@joeflack4 joeflack4 linked a pull request Jan 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
3 participants