Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message timestamps are shown in 12h format #381

Open
1 task done
jayb-g opened this issue Jul 14, 2024 · 9 comments
Open
1 task done

Message timestamps are shown in 12h format #381

jayb-g opened this issue Jul 14, 2024 · 9 comments

Comments

@jayb-g
Copy link

jayb-g commented Jul 14, 2024

Is there an existing request for this?

  • I have searched the existing issues

Bug description

All timestamps on messages are 12h format regardless of if device time format is set to 24h. Apparently Signal doesn't have this problem. Maybe molly missed some commits ? Is it intentional?

@jayb-g
Copy link
Author

jayb-g commented Oct 15, 2024

There's a closed issue on signal android due to being stale. But as of now signal android does show timestamps as expected, in 24h format. Couldn't find what/when it got fixed.

Did molly miss some commits and just bumped versions to match with signal versions ? Is it intentional/necessary? How to compare the two?

I thought molly just rebases the commits on top of latest signal commits. I understand it might be more complicated to do than a simple rebase due to a lot of changes, but that's what it basically should be, no?

@valldrac valldrac transferred this issue from mollyim/mollyim-android-unifiedpush Oct 16, 2024
@valldrac
Copy link
Member

I tested Signal v7.20.1, it displays time in 12h format when the language is set to English, regardless of device settings.

In Signal, overriding the language sets the app’s locale, which includes the time format. There’s no difference between Molly and Signal on that.

There might be some inconsistencies in certain fields due to a reported bug in Signal where the locale can sometimes reset. However, I haven't been able to replicate this issue, and it's different from what you're mentioning, which is how the language setting is designed to work in the app.

@jayb-g
Copy link
Author

jayb-g commented Oct 16, 2024

I have Signal 7.19.2 with language set as 'system default', which is English already. It has 24h timestamps.

@valldrac
Copy link
Member

The "system default" option keeps the locale unchanged, meaning the system's time settings stay as they are. But if you switch it to English, the 12h American format will be used.

Have you noticed any differences between Molly and Signal?

@jayb-g
Copy link
Author

jayb-g commented Oct 16, 2024

Yes, same settings. Same device. Molly has 12h format. Molly 7.17.5-1.up1-FOSS

@jayb-g
Copy link
Author

jayb-g commented Oct 16, 2024

The "system default" option keeps the locale unchanged, meaning the system's time settings stay as they are.

doesn't seem to be the case for molly.

But if you switch it to English, the 12h American format will be used.

If you switch back to system default from English, does it go back to 24h format?

@valldrac
Copy link
Member

Yes, same settings. Same device. Molly has 12h format. Molly 7.17.5-1.up1-FOSS

Do you have passphrase database encryption enabled in Molly? I found a possible cause related to this.

@jayb-g
Copy link
Author

jayb-g commented Oct 16, 2024

Nope. Everything default. No encryption for database.

One thing I might have done different is I restored chats from a signal backup. And changed notifications to unifiedpush. Up and running. That's it. No other changes at all.

@jayb-g
Copy link
Author

jayb-g commented Oct 17, 2024

I hope you're able to reproduce it. Or maybe some other users having same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants