Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Heroku-16 stack available #7

Open
nateberkopec opened this issue Apr 20, 2017 · 3 comments
Open

New Heroku-16 stack available #7

nateberkopec opened this issue Apr 20, 2017 · 3 comments

Comments

@nateberkopec
Copy link
Collaborator

Not sure if we actually need to change anything for this or not
@mojodna
Copy link
Owner

mojodna commented Apr 20, 2017

May need to recompile, in which case multiple versions will need to exist, e.g. https://github.com/mojodna/heroku-buildpack-cairo/blob/master/bin/compile#L45

@nateberkopec
Copy link
Collaborator Author

Heroku says it "should work" with buildpacks for Cedar, but who knows.

@brian-kephart
Copy link

I've been using this buildpack on Heroku-16 for a couple months. It works just fine.

gaffneyc referenced this issue in gaffneyc/heroku-buildpack-jemalloc Dec 5, 2017
@gaffneyc
Rewrite build system for new versions and Heroku stacks
4461dd3 
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #7
Fixes #13
@gaffneyc gaffneyc mentioned this issue Dec 5, 2017
Closed
gaffneyc referenced this issue in gaffneyc/heroku-buildpack-jemalloc Dec 5, 2017
@gaffneyc
Rewrite build system for new versions and Heroku stacks
71ac02c 
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes #7
Fixes #13
gaffneyc referenced this issue in gaffneyc/heroku-buildpack-jemalloc Dec 5, 2017
@gaffneyc
Rewrite build system for new versions and Heroku stacks
81173ed 
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes #7
Fixes #13
@gaffneyc gaffneyc mentioned this issue Dec 11, 2017
Closed
@prathamesh-sonpatki prathamesh-sonpatki mentioned this issue Jun 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mojodna @nateberkopec @brian-kephart