Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 4.0.4 #2

Open
nateberkopec opened this issue Jan 15, 2016 · 10 comments
Open

Upgrade to 4.0.4 #2

nateberkopec opened this issue Jan 15, 2016 · 10 comments

Comments

@nateberkopec
Copy link
Collaborator

No description provided.

@nateberkopec
Copy link
Collaborator Author

Also, it'd be nice if we could download jemalloc from some more official source.

EDIT: You could probably add it to the git repo here and use something like rawgit.com to download from it.

@mojodna
Copy link
Owner

mojodna commented Jan 18, 2016

Agreed, though it needs to be built at some point. Adding it to the git repo would make it available at build time (w/o the download), but would also bloat the repo some, slowing things down.

Attaching it to a release might actually do the trick. I'll try creating a release for the current version and adding the binary.

(I don't actually use this buildpack--it was to facilitate some experiments a while back, so if you'd like to potentially adopt it, let me know.)

@mojodna
Copy link
Owner

mojodna commented Jan 18, 2016

Yup, looks like that would work: https://github.com/mojodna/heroku-buildpack-jemalloc/releases/tag/v3.6.0

@nateberkopec
Copy link
Collaborator Author

@mojodna perhaps could adopt it, let me work a little more with it first. but it works great in production with the new buildpacks features, so I think more people should be looking at this.

@mojodna
Copy link
Owner

mojodna commented Jan 18, 2016

Sweet, keep me posted!

@heaven
Copy link
Contributor

heaven commented Jun 23, 2016

Hi, any luck with building this? 4.2.1 is already available.

@nateberkopec
Copy link
Collaborator Author

Simply haven't had time - everything you need in the repo is there if you want to give it a shot! Will accept PRs.

@brian-kephart
Copy link

v5.0.0 just came out today. I'd do a PR for it, but I don't know how the build process works when building for a different environment than my local machine. How has this been done in the past?

@mojodna
Copy link
Owner

mojodna commented Jun 15, 2017

There's a Makefile in the root that uses Docker to build it against the Heroku image (and extract it so that it can be uploaded to GitHub for referencing by bin/compile).

@mojodna
Copy link
Owner

mojodna commented Jun 15, 2017

0938c22 is largely suitable for a PR (without the line I commented on).

gaffneyc referenced this issue in gaffneyc/heroku-buildpack-jemalloc Dec 5, 2017
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes #7
Fixes #13
gaffneyc referenced this issue in gaffneyc/heroku-buildpack-jemalloc Dec 5, 2017
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes #7
Fixes #13
bf4 pushed a commit to bf4/heroku-buildpack-jemalloc that referenced this issue Sep 3, 2018
After a few months of testing 5.1.0 appears to be stable and working
well. It is a recommended upgrade by the jemalloc team.

Closes mojodna#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants