Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: try retryable http-client for remote trigger #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

androndo
Copy link
Contributor

PR Summary

Additional information

Closes/Relates #issue

@androndo androndo requested a review from a team as a code owner June 16, 2021 10:35
@codecov-commenter
Copy link

Codecov Report

Merging #641 (11421d3) into master (1f1d72e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   69.25%   69.24%   -0.02%     
==========================================
  Files         170      170              
  Lines        7624     7627       +3     
==========================================
+ Hits         5280     5281       +1     
- Misses       2010     2012       +2     
  Partials      334      334              
Impacted Files Coverage Δ
metric_source/remote/remote.go 92.30% <100.00%> (+0.64%) ⬆️
database/redis/database_dialer.go 45.83% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1d72e...11421d3. Read the comment docs.

@androndo
Copy link
Contributor Author

This fix deployed temporally from branch feature/fix_remote_datasource_via_retryable_client_rebase with other checker fixes, need remove this tmp branch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants