-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger name limit #1080
base: master
Are you sure you want to change the base?
feat: trigger name limit #1080
Conversation
limits := middleware.GetLimits(request) | ||
if utf8.RuneCountInString(trigger.Name) > limits.Trigger.MaxNameSize { | ||
return api.ErrInvalidRequestContent{ | ||
ValidationError: fmt.Errorf("trigger name too long, should not be greater than %d symbols", limits.Trigger.MaxNameSize), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а эту тогда ошибку почему не утащил наверх?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А тут параметр есть, поэтому не стал...
/build |
Build and push Docker images with tag: feat-trigger-name-limit.2024-09-27.7bcb0da |
1 similar comment
Build and push Docker images with tag: feat-trigger-name-limit.2024-09-27.7bcb0da |
PR Summary
Before this PR there was no limit to trigger name. This can lead to problems with alert delivering.
This PR adds configurable limit for trigger name. It is highly recommended not to increase it.